#147 ✓resolved

getElementByTagName needs tests

Reported by nickg | April 2nd, 2010 @ 03:46 AM

Found this..
JS strict warning #156 in env.js at line 1738 - assignment to undeclared variable nodeList

which lead to this in node.js

    getElementsByTagName : function(tagname) {
        // delegate to _getElementsByTagNameRecursive                                                                      
        // recurse childNodes                                                                                              
    var nodelist = new NodeList(__ownerDocument__(this));
        for(var i = 0; i < this.childNodes.length; i++) {
            nodeList = __getElementsByTagNameRecursive__(this.childNodes.item(i), tagname, nodelist);
        return nodelist;

looks like nodeList vs nodelist. Might have been caused by me with some editor problem.

Need tests.

Comments and changes to this ticket

  • nickg

    nickg April 2nd, 2010 @ 12:21 PM

    • State changed from “new” to “open”
    • Assigned user set to “nickg”

    I have a test just need to check it in

    "nodeList" is just bogus can be removed.....

  • nickg

    nickg April 6th, 2010 @ 03:56 AM

    • State changed from “open” to “resolved”

    tests were committed a few days ago.


Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

a javascript browser environment

People watching this ticket