#74 ✓resolved
George V. Reilly

test/testrunner.js: cannot read/write innerHTML property.

Reported by George V. Reilly | September 22nd, 2009 @ 01:59 PM | in 1.1 Release

I get the following errors whenever I use testrunner.js:
js: uncaught JavaScript runtime exception: TypeError: Cannot read property "innerHTML" from null js: uncaught JavaScript runtime exception: TypeError: Cannot set property "innerHTML" of null to "undefined" Same environment and test as http://envjs.lighthouseapp.com/projects/21590/tickets/73-non-fatal-...

This patch works around it.

*** c:test\testrunner.js Wed Sep 09 22:22:42 2009 --- d:test\testrunner.js Thu Sep 17 18:09:56 2009

* 14,27 **

}

}

! var orig = document.getElementById('main').innerHTML; //var orig = document.getElementById('main').cloneNode(true);

/* * Resets the test setup. Useful for tests that modify the DOM. / function reset() { ! document.getElementById('main').innerHTML = orig; }

var currentModule = ""; --- 14,27 ----

}

}

! / var orig = document.getElementById('main').innerHTML; // gvr / //var orig = document.getElementById('main').cloneNode(true);

/* * Resets the test setup. Useful for tests that modify the DOM. / function reset() { ! / document.getElementById('main').innerHTML = orig; // gvr / }

var currentModule = "";

232,235 ** / function url(value) {

return value + (/\?/.test(value) ? "&" : "?") + new Date().getTime() + "" + parseInt(Math.random()*100000);

! } \ No newline at end of file --- 232,235 ---- */ function url(value) {

return value + (/\?/.test(value) ? "&" : "?") + new Date().getTime() + "" + parseInt(Math.random()*100000);

! }

Comments and changes to this ticket

  • George V. Reilly

    George V. Reilly September 22nd, 2009 @ 02:06 PM

    Let's try that patch again. Lighthouse mangled the formatting.

    *** c:test\testrunner.js    Wed Sep 09 22:22:42 2009
--- d:test\testrunner.js    Thu Sep 17 18:09:56 2009
***************
*** 14,27 ****
    }
  }

! var orig = document.getElementById('main').innerHTML;
  //var orig = document.getElementById('main').cloneNode(true);

  /**
   * Resets the test setup. Useful for tests that modify the DOM.
   */
  function reset() {
!   document.getElementById('main').innerHTML = orig;
  }

  var currentModule = "";
--- 14,27 ----
    }
  }

! /* var orig = document.getElementById('main').innerHTML; // gvr  */
  //var orig = document.getElementById('main').cloneNode(true);

  /**
   * Resets the test setup. Useful for tests that modify the DOM.
   */
  function reset() {
! /*    document.getElementById('main').innerHTML = orig; // gvr */
  }

  var currentModule = "";
***************
*** 232,235 ****
   */
  function url(value) {
    return value + (/\?/.test(value) ? "&" : "?") + new Date().getTime() + "" + parseInt(Math.random()*100000);
! }
\ No newline at end of file
--- 232,235 ----
   */
  function url(value) {
    return value + (/\?/.test(value) ? "&" : "?") + new Date().getTime() + "" + parseInt(Math.random()*100000);
! }
  • George V. Reilly

    George V. Reilly September 22nd, 2009 @ 02:08 PM

    • Assigned user set to “Thatcher”
  • Thatcher

    Thatcher October 28th, 2009 @ 01:23 PM

    • State changed from “new” to “open”
    • Milestone set to “1.1 Release”

    [responsible:id#36440 state:"open" milestone:id#49862 bulk edit command]

  • Thatcher

    Thatcher November 12th, 2009 @ 05:02 AM

    • State changed from “open” to “resolved”

    should be fixed as a result of a reorg of the unit tests in general. Let me know if I'm mistaken.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

a javascript browser environment

People watching this ticket

Pages