#116 ✓resolved
nickg

PATCH: Typo in cookie.js/document.js "splt" should be "split"

Reported by nickg | March 17th, 2010 @ 02:54 PM

This causes the basic cookie functions to fail.

here's the fix

http://github.com/client9/env-js/commit/eb504cd0501a142ea7f29834a85...

diff --git a/src/html/cookie.js b/src/html/cookie.js
index b560ec7..45be585 100644
--- a/src/html/cookie.js
+++ b/src/html/cookie.js
@@ -33,7 +33,7 @@ Cookies.set = function(doc, cookie){
     
     var domainValid = function(doc, value){
         var i,
-            domainParts = doc.domain.splt('.').reverse(),
+            domainParts = doc.domain.split('.').reverse(),
             newDomainParts = value.split('.').reverse();
         if(newDomainParts.length > 1){
             for(i=0;i<newDomainParts.length;i++){
diff --git a/src/html/document.js b/src/html/document.js
index bbe7c35..f7b1eed 100644
--- a/src/html/document.js
+++ b/src/html/document.js
@@ -246,7 +246,7 @@ __extend__(HTMLDocument.prototype, {
     },
     set domain(value){
         var i,
-            domainParts = this.domain.splt('.').reverse(),
+            domainParts = this.domain.split('.').reverse(),
             newDomainParts = value.split('.').reverse();
         if(newDomainParts.length > 1){
             for(i=0;i<newDomainParts.length;i++){

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

a javascript browser environment

People watching this ticket

Tags

Pages