Envjs envjs

Comments and changes to this ticket

• You flagged this item as spam.
  

  d0rc March 21st, 2010 @ 05:08 AM

  • Assigned user set to “Thatcher”
• 

  nickg March 24th, 2010 @ 06:42 PM

  • Tag set to “location”
  • State changed from “new” to “open”
  • Assigned user changed from “Thatcher” to “nickg”

  hi,

  please pull the latest changes and see if it solves your issues.

  thanks,

  --nickg

• 

  nickg March 30th, 2010 @ 03:02 AM

  Uh oh:

  src/html/document.js

  get location() {
  
  
  
  
  
  
  

      if (this.ownerWindow) {
          return this.ownerWindow.location;
      } else {
          return this.baseURI;
      }
  },
  set location(url) {
      this.baseURI = url;
      if (this.ownerWindow) {
          this.ownerWindow.location = url;
      }
  },
  

  overwritten with:

  src/xhr/document.js

      get location(){
  
  
  
  
  
  
  

  return new Location(this.documentURI, this);
  },
  set location(url){
  //very important or you will go into an infinite                                                                            
  //loop when creating a xml document                                                                                         
  if(url) {
          this.location.replace(url);
  }
  }</code>
  

  need investigation

• 

  nickg April 8th, 2010 @ 03:22 PM

  I still see this occasionally. Not sure how location is not getting set.

  I'm working on it.

• 

  nickg April 11th, 2010 @ 10:51 AM

  a few fixes are in for this problem, but it's still not completely correct.

  Right now, each "module directory" (e.g dom, parser, css, html, etc) has it's own tests and each module loads in just what it needs to run the test.

  I have an alteranate test harness that loads in all of env.(rhino).js and runs the tests that way.

  one-at-a-time: all tests pass
  env.js + test: document.location test is failing!

  we are getting closer...

  --nickg