Nodelist : Function.prototype.apply must take an array

can you describe an example which produces this error?

I applied the patch but put a comment referencing back to this ticket. Still haven't figured out why this can happen since .childNodes should always be an array.

I ran into a related problem with DocumentFragments and nodeList's with the latest build ( downloaded April 28, 2009 ) and using the jQuery UI plugin.

It seems that rhino is treating the childNodes(nodeList) object as an object, not as an array.

A simple scenario to reproduce:

var div = document.createElement ( 'div' );
var df = document.createDocumentFragment();
df.appendChild ( document.createElement ( 'p' ) );
div.appendChild ( df );

// at this point, div.childNodes is corrupted, with childNodes[0] being a nodeList, not a node

div.childNodes 
[ [ Element #3 P ] ]

Patch to fix:

diff --git a/src/dom/nodelist.js b/src/dom/nodelist.js index 04473ef..701060e 100644 --- a/src/dom/nodelist.js +++ b/src/dom/nodelist.js @@ -53,6 +53,13 @@ extend(DOMNodeList.prototype, {

     return ret;
 },

• toArray: function () {
  
  

•         var children = [];
  
  

•         for ( var i=0; i < this.length; i++) {
  
  

•                 children.push (this[i]);
  
  

•         }
  
  

•         return children;
  
  

• },
  
  

  toString: function(){ return "[ "+(this.length > 0?Array.prototype.join.apply(this, [", "]):"Empty NodeList")+" ]"; } @@ -96,7 +103,7 @@ var insertBefore = function(nodelist, newChild, refChildIndex) {

   if (newChild.nodeType == DOMNode.DOCUMENT_FRAGMENT_NODE) {  // node is a DocumentFragment
       // append the children of DocumentFragment
  
  

•      Array.prototype.splice.apply(nodelist,[refChildIndex, 0].concat(newChild.childNodes));
  
  

•      Array.prototype.splice.apply(nodelist,[refChildIndex, 0].concat(newChild.childNodes.toArray()));
   }
   else {
       // append the newChild
  
  

  @@ -122,7 +129,7 @@ var replaceChild = function(nodelist, newChild, refChildIndex) {

   if (newChild.nodeType == DOMNode.DOCUMENT_FRAGMENT_NODE) {  // node is a DocumentFragment
       // get array containing children prior to refChild
  
  

•      Array.prototype.splice.apply(nodelist,[refChildIndex, 1].concat(newChild.childNodes));
  
  

•      Array.prototype.splice.apply(nodelist,[refChildIndex, 1].concat(newChild.childNodes.toArray()));
   }
   else {
       // simply replace node in array (links between Nodes are made at higher level)
  
  

  @@ -164,12 +171,7 @@ var removeChild = function(nodelist, refChildIndex) { */ var appendChild = function(nodelist, newChild) { if (newChild.nodeType == DOMNode.DOCUMENT_FRAGMENT_NODE) { // node is a DocumentFragment

•  // append the children of DocumentFragment
  
  

•  //TODO : see [#14](/projects/21590/tickets/14 "Ticket #14") - http://envjs.lighthouseapp.com/p...
  
  

•  //not sure why this could happen, .childNodes should always be an array
  
  

•  Array.prototype.push.apply(nodelist,
  
  

•      (newChild.childNodes instanceof Array) ?
  
  

•          newChild.childNodes : [newChild.childNodes]);
  
  

•  Array.prototype.push.apply(nodelist, newChild.childNodes.toArray() );
  
  

  } else {

   // simply add node to array (links between Nodes are made at higher level)
   Array.prototype.push.apply(nodelist, [newChild]);
  
  

• Mike Doyle