#141 new
nickg

Multiplely included files, functions in dist/env.js

Reported by nickg | March 28th, 2010 @ 12:53 PM

Hola,

Right now in the final env.X.js file.... urlparse.js is include twice. entend.js is include 5? times. I think Aspect.js will want to be included in multiple places too.

Do we want a envjs-common.js file to be used and reused, so items are included once?

Thoughts welcome!

--nickg

Comments and changes to this ticket

  • Thatcher

    Thatcher March 29th, 2010 @ 03:22 PM

    Theres really not a good reason to include a file more than 10 line twice.
    In fact all of the file included mutliple times might as well become methods
    of envjs. extend was a bad example to try to reuse.

    Does that seem reasonable to you too?

  • nickg

    nickg March 29th, 2010 @ 03:26 PM

    agreed: all those small functions should be a method of Envjs. Most of those are utilities anyways. And trim actually might want to be overridden (rhino oddly doesn't have string.trim, while spidermonkey, others have it natively).

    What about bigger files like urlparse.js and aspect.js?

    --nickg

  • Thatcher

    Thatcher March 29th, 2010 @ 04:14 PM

    Also Envjs.functions i guess. we could go back to making Envjs it's own
    closure so some bigger routine can be encapuslated. It's sort of 6 one way,
    1/2 dozen the other. I'm almost dug out of my open source back logs, the
    way-over-due stuff anyway, but I'm not a control freak so I'll let you and
    the team decide whats best. The good thing about putting it inside the
    Envjs closure is that we can abstract the implementation, but my opinion is
    once its pure js-ish it might as well be directly on Envjs since that's
    basically our goal.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

a javascript browser environment

People watching this ticket

Pages