#55 ✓invalid
sean (at msgilligan)

DOMAttr.xml returns single-quoted attributes

Reported by sean (at msgilligan) | March 9th, 2009 @ 09:12 AM

XML attribute values should be surrounded by double-quotes

The current source in src/dom/attr.js returns attribute values surrounded by single quotes

I created a fork on github with a proposed solution: http://github.com/msgilligan/env...

Comments and changes to this ticket

  • Thatcher

    Thatcher March 24th, 2009 @ 04:13 PM

    • Tag set to attribute, qoute, serialization, xml
    • State changed from “new” to “open”
    • Assigned user set to “Thatcher”

    so I had some debates about this with some xml folks. The result is I lost and quotes shouldn't matter.

    However, I still think this is the defacto behaviour so I'm going to change it.

  • Thatcher

    Thatcher September 9th, 2009 @ 04:27 PM

    • State changed from “open” to “invalid”

    decided not to change this as neither xml nor html require double quotes

  • sean (at msgilligan)

    sean (at msgilligan) September 9th, 2009 @ 04:51 PM

    There is a very strong pragmatic argument for this feature. If you want to use env.js to do command line XML processing you want to be able to have the format of your output be as close as possible to the format of your input. Double-quotes should not change to single-quotes. It's a 'round-tripping' thing.

    There is a general rule about being generous about what you accept and rigorous in what you output. I think this rule should apply to de facto standards as well.

    I have a patch and am willing to resubmit based on current source.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

a javascript browser environment

People watching this ticket