Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Event.target not properly set through constructor

#67

In the Event constructor, $target is never set properly. The fix is easy (surely a copy-paste error)

In :

  $debug("Creating new Event");
  var $bubbles = options.bubbles?options.bubbles:true,

  $cancelable = options.cancelable?options.cancelable:true,
  $currentTarget = options.currentTarget?options.currentTarget:null,
  $eventPhase = options.eventPhase?options.eventPhase:Event.CAPTURING_PHASE,
  $target = options.eventPhase?options.eventPhase:document,
  $timestamp = options.timestamp?options.timestamp:new Date().getTime().toString(),
  $type = options.type?options.type:&quot;&quot;;</code>



Change the line

      $target = options.eventPhase?options.eventPhase:document,

to

      $target = options.target?options.target:document,

Reported by Jonathan R.-Brochu · May 22nd, 2009 @ 02:37 AM

State: resolved
Milestone: 1.0 Release
Assigned to: Thatcher Thatcher

Activity

  1. Jonathan R.-Brochu
  2. Thatcher
    Thatcher
    • Milestone set to 1.0 Release
    • State changed from new to resolved
    • Assigned user set to Thatcher

    gosh Jonathan sorry for the tremendous delay. I got this in my local git and will push it out with a couple other small patches tomorrow

    September 9th, 2009 @ 04:56 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.