#67 ✓resolved
Jonathan R.-Brochu

Event.target not properly set through constructor

Reported by Jonathan R.-Brochu | 2009-05-22 02:37:09 UTC | in 1.0 Release

In the Event constructor, $target is never set properly. The fix is easy (surely a copy-paste error)

In :

  $debug("Creating new Event");
  var $bubbles = options.bubbles?options.bubbles:true,

  $cancelable = options.cancelable?options.cancelable:true,
  $currentTarget = options.currentTarget?options.currentTarget:null,
  $eventPhase = options.eventPhase?options.eventPhase:Event.CAPTURING_PHASE,
  $target = options.eventPhase?options.eventPhase:document,
  $timestamp = options.timestamp?options.timestamp:new Date().getTime().toString(),
  $type = options.type?options.type:&quot;&quot;;</code>



Change the line

      $target = options.eventPhase?options.eventPhase:document,

to

      $target = options.target?options.target:document,

Comments and changes to this ticket

  • Jonathan R.-Brochu

    Jonathan R.-Brochu 2009-05-22 02:56:43 UTC

    • Tag set to “class, event”
  • Thatcher

    Thatcher 2009-09-09 16:56:17 UTC

    • Milestone set to “1.0 Release”
    • State changed from “new” to “resolved”
    • Assigned user set to “Thatcher”

    gosh Jonathan sorry for the tremendous delay. I got this in my local git and will push it out with a couple other small patches tomorrow

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

a javascript browser environment

People watching this ticket

Tags

Pages