Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

document.location.host value always ':'

#79

The logic for determining the document.location.host has a misplaced ) which results in the value returned always being :

For example if the URL is http://some.domain.name:8080/my/file.html the values below should be:

document.location.hostname -> some.domain.name
document.location.port -> 8080
document.location.host -> some.domain.name:8080

the common exception in browsers is that ports 80 and 443 are always hidden if the protocols are http and https respectively, even if manual entered into the URL.

The correct logic is used for set hostname() and can be used for get host() in:

src/html/anchor.js
src/window/location.js

Reported by Liam Clancy (metafeather) · November 24th, 2009 @ 07:23 AM

State: resolved
Milestone: 1.2.x
Assigned to: Thatcher Thatcher

Activity

  1. Liam Clancy (metafeather)
  2. Thatcher
    Thatcher
    • Assigned user set to Thatcher

    thanks liam, I will get this pulled in tonight!

    November 24th, 2009 @ 04:06 PM

  3. Thatcher
    Thatcher
    • Milestone set to 1.2.x
    • State changed from new to open

    This is one of those embarrassing tickets because I said it was already going to have been fixed. Hopefully it is now but I will verify before I close the ticket. Sorry! But thanks for the ticket because it doe mean if I forget I can't forget forever

    February 3rd, 2010 @ 04:45 PM

  4. Thatcher
    Thatcher
    • State changed from open to resolved
    • Tag set to location xhr port host hostname

    I believe this is fixed in trunk. Check out the test/specs/xhr/spec.js which can be run in both envjs via

    ant xhr-spec

    or loaded as html in ff to verify.

    February 5th, 2010 @ 05:10 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.