Script tags aren't being executed as expected
-
nickg
More specifically, I think the fix is the following.
diff --git a/src/platform/core/html.js b/src/platform/core/html.js index 467e643..781d04f 100644 --- a/src/platform/core/html.js +++ b/src/platform/core/html.js @@ -62,7 +62,7 @@ Envjs.loadLocalScript = function(script){ if(i+1 == types.length) return false; } - }else{ + } try{ //handle inline scripts if(!script.src) @@ -73,7 +73,7 @@ Envjs.loadLocalScript = function(script){ Envjs.onScriptLoadError(script, e); return false; } - } + if(script.src){ @@ -125,4 +125,4 @@ Envjs.loadLocalScript = function(script){ } return true; }; - \ No newline at end of file + -
Thatcher
- Assigned user set to Thatcher
- State changed from new to resolved
- Tag set to linline, script, type
- Milestone set to 1.2.x
done and committed!
http://github.com/thatcher/env-js/commit/f39ab7c539af81cecc41ef8cc6...thanks guys!
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.