stray debug console.log in code (src/eventtarget.js)
Reported by nickg | March 14th, 2010 @ 06:54 PM | in 1.2.x
Looks like the trunk has an unintended debug console.log in place. All others in the source are commented out.
Around line 132 in src/eventtarget.js
if(!event._preventDefault){
//At this point I'm guessing that just HTMLEvents are concerned
//with default behavior being executed in a browser but I could be
//wrong as usual. The goal is much more to filter at this point
//what events have no need to be handled
console.log('triggering default behavior for %s', event.type); // <---- HERE
if(event.type in Envjs.defaultEventBehaviors){
Envjs.defaultEventBehaviors[event.type](event);
}
Comments and changes to this ticket
-
nickg March 15th, 2010 @ 04:41 AM
I attempted a github pull request which may or may not work!
it's a tester before more interesting changes.--nickg
-
nickg March 15th, 2010 @ 07:28 PM
- Assigned user set to “Thatcher”
http://github.com/client9/env-js/commit/ff17aaf183275f8ceb4327c6203...
giving to thatcher for merge
-
Thatcher March 16th, 2010 @ 05:13 PM
yeah I found this too, it was a stray artifact of some work I'm doing to
provide default html event behaviors. sorry! I'm going to push out this
first before I pull in the rest of these patches. -
-
Thatcher March 17th, 2010 @ 04:31 PM
thanks, my brain is skipping sometimes when multitasking. need more ram.
-
Thatcher March 17th, 2010 @ 04:40 PM
- State changed from “new” to “resolved”
- Milestone set to “1.2.x”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
a javascript browser environment
Thatcher