Envjs envjs

Comments and changes to this ticket

• 

  nickg 2010-03-26 16:26:04 UTC

  hi, I hope in short order to be porting or generalizing envjs to work with other engines so I appreciate the ticket.

  this appears to be a odd spidermonkey/rhino extension, although it's claimed to be part of the js1.6 spec, which means it should be part of v8.

  https://developer.mozilla.org/en/Core_JavaScript_1.5_Reference/Stat...

  i've never used e4x, but it seems that:

     for each(xnode in e4){
      kind = xnode.nodeKind();
  

  could be converted to

  for (xnode_name in e4) {
     kind = xnode[xnode_name];
  

  ??? thoughts welcome here.

• 

  nickg 2010-03-26 16:26:54 UTC

  sorry that should have been:

  for (xnode_name in e4) {
     kind = xnode[xnode_name].nodeKind();
  

  or something damn similar.

• 

  nickg 2010-03-27 04:16:09 UTC

  Does this look right to you?

  @@ -33,8 +33,9 @@ var __toDomNode__ = function(e4, parent, doc){
           element,
           kind;
       //console.log('converting e4x node list \n %s', e4)
  -    for each(xnode in e4){
  -        kind = xnode.nodeKind(); 
  +    for (item in e4) {
  +        xnode = e4[item];
  +        kind = xnode.nodeKind();
           //console.log('treating node kind %s', kind);
           switch(kind){
               case 'element':
  

• 

  nickg 2010-03-27 04:17:29 UTC

  take 2

   var __toDomNode__ = function(e4, parent, doc){
  -    var xnode, 
  +    var xnode,
           domnode,
           children,
           target,
           value,
           length,
           element,
  -        kind;
  +        kind,
  +        item;
       //console.log('converting e4x node list \n %s', e4)
  -    for each(xnode in e4){
  -        kind = xnode.nodeKind(); 
  +    for (item in e4) {
  +        xnode = e4[item];
  +        kind = xnode.nodeKind();
           //console.log('treating node kind %s', kind);
  

• 

  nickg 2010-03-27 04:34:52 UTC

  • State changed from “new” to “resolved”
  • Assigned user changed from “Thatcher” to “nickg”

  pushed!

  http://github.com/thatcher/env-js/commit/cb2f6c5bc3ffaad09f60a9728c...

• 

  Thatcher 2010-03-28 10:20:58 UTC

  wow just catching up on this thread. I wasnt sure e4x was supported in V8
  but I'm thrilled to hear it is now! Nice work guys!