Results of strict mode on 'env.js'

I couldn't help myself.

http://github.com/thatcher/env-js/commit/7879a696e8e7bfaa6259bc626e...

fixes

JS strict warning #156 in env.js at line 5129 - assignment to undeclared variable node
JS strict warning #156 in env.js at line 7768 - assignment to undeclared variable HTMLParagraphElement

The first of which is semi-serious depending how the async/parser works, and certainly pollutes global namespace with a common name. (this is in the main document.createElement function)

The second is just cause I probably caused the error.

Nice.

I found the node one with a tweak I've been playing with on my fork: loading the DOM classes into their own global object and importing them into individual windows. Highlighted every global that wasn't supposed to be there. This is the only one that I really remember. I thought I checked to see if it had been fixed in 1.2 but obviously I messed up some how.

I run all my code through jslint on every save. Unfortunately, until Crockford (or someone else) decides to implement getters/setters, it's a non-starter for envjs.

The emacs JS2 mode actually finds things like unmatched returns.

I think I tried running envjs compressed by YUI and Closure and it failed afterwards. Be nice if we could make that work ... I wonder if it would speed anything up? Perhaps not, but ...

yeah crockford ain't too keen on adding support for getters/setters, huh? I saw your post to the group too. He's been cranky about them for years. Oh well.

I attempted a patch, it's close, but not quite close enough. The problem with parsers like these is that unless you really dig into and work with it every day, it's really tough to understand. And honestly, he'll never integrate it.

But I have an even better hack which allows jslint to work. Quick tests show:
* the division of directories into separate files (e.g. html.js, dom.js, console.js, etc) don't really work well since they have dependencies on other modules. * each module has some ordering problems in terms of how the files are arranged. * lots of warnings about == vs. === * Missing semi-colons

In other words, the usual stuff!

I'll try and set up an automated dump of the results shortly.

--nickg

ok attached jslint output.

A lot of these could be avoided by better ordering of the code. I post my script that generated this later...

Executive summary! 592 total errors, with a very loose set of options for jslint, and the HTMLParser stuff ripped out.

$ ./jslintparser.py < lintout.txt
Missing '()' invoking a constructor.                            71
'__ownerDocument__' is not defined.                             46
Missing semicolon.                                              37
Unnecessary semicolon.                                          33
Mixed spaces and tabs.                                          30
Expected '{' and instead saw 'a'.                               18
Expected '{' and instead saw 'return'.                          15
'__eval__' is not defined.                                      12
Wrap the entire immediate function invocation in parens.        12
Move the invocation into the parens that contain the function.    12
The body of a for in should be wrapped in an if statement to filter unwanted properties from the prototype.    11
Read only.                                                       8
'window' is not defined.                                         8
'$css2properties' is not defined.                                7
'e' is already defined.                                          6
'logFormatted' is not defined.                                   6
'i' is already defined.                                          6
Use '===' to compare with 'null'.                                6
Expected '{' and instead saw 'this'.                             5
'i' is not defined.                                              5
Expected an assignment or function call and instead saw an expression.     5
Missing radix parameter.                                         5
Use '===' to compare with '0'.                                   4
'appendText' is not defined.                                     4
Bad escapement.                                                  4
Don't make functions within a loop.                              4
'go' is not defined.                                             4
'__isAncestor__' is not defined.                                 3
'__toCamelCase__' is not defined.                                3
'override' is not defined.                                       3
'__fieldValue__' is not defined.                                 3
'__isValidNamespace__' is not defined.                           3
'__findNamedItemIndex__' is not defined.                         3
Unnecessary escapement.                                          3
'__findNamedItemNSIndex__' is not defined.                       3
Expected '{' and instead saw 'Envjs'.                            3
Do not use 'new' for side effects.                               3
Expected '{' and instead saw 'aspect'.                           3
'Window' is not defined.                                         3
Expected '{' and instead saw 'element'.                          3
'__windows__' is not defined.                                    3
Bad line breaking before '&&'.                                   3
'XML' is not defined.                                            3
Expected a 'break' statement before 'default'.                   3
Expected '{' and instead saw 'appendText'.                       3
Expected '{' and instead saw 'continue'.                         3
'console' is not defined.                                        3
'__cssTextToStyles__' is not defined.                            2
Expected '{' and instead saw 'appendNull'.                       2
Use '===' to compare with 'undefined'.                           2
Extra comma.                                                     2
'newChild' is already defined.                                   2
'appendObject' is not defined.                                   2
Use '!==' to compare with '0'.                                   2
Expected '{' and instead saw 'attrstring'.                       2
Expected an identifier and instead saw 'eval' (a reserved word).     2
'__isValidString__' is not defined.                              2
Expected '{' and instead saw 'accumulateText'.                   2
'appendInteger' is not defined.                                  2
'$left' is not defined.                                          2
Expected '{' and instead saw 'array'.                            2
Expected '{' and instead saw 'html'.                             2
Use '!==' to compare with 'null'.                                2
'__isIdDeclaration__' is not defined.                            2
'__toDashed__' is not defined.                                   2
Expected '.' and instead saw ';'.                                2
Expected '{' and instead saw 'ns'.                               2
'__param__' is not defined.                                      2
Expected '{' and instead saw '_window'.                          2
'$top' is not defined.                                           2
['BUBBLING'] is better written in dot notation.                  2
Expected an identifier and instead saw 'arguments' (a reserved word).     2
['CAPTURING'] is better written in dot notation.                 2
'__exchangeHTMLDocument__' is not defined.                       2
'$availTop' is not defined.                                      2
Confusing use of '!'.                                            2
'Cookies' is not defined.                                        2
Expected '{' and instead saw 'successful'.                       1
'HTMLDocument' is not defined.                                   1
'__bubbleEvent__' is not defined.                                1
'__submit__' is not defined.                                     1
'max' is not defined.                                            1
'trim' is not defined.                                           1
'console' was used before it was defined.                        1
'appendFloat' is not defined.                                    1
'inserted' is already defined.                                   1
'value' is already defined.                                      1
'object' is already defined.                                     1
'HTMLDocument' was used before it was defined.                   1
Bad for in variable 'name'.                                      1
'__window__resizeTo' is not defined.                             1
'appendObjectFormatted' is not defined.                          1
'NamespaceNodeMap' is not defined.                               1
'__removeEventListener__' is not defined.                        1
'data' is not defined.                                           1
'pointcut' is not defined.                                       1
Bad for in variable 'index'.                                     1
Use '===' to compare with 'false'.                               1
'__top__' is not defined.                                        1
Redefinition of 'clearTimeout'.                                  1
A constructor name should start with an uppercase letter.        1
'XMLList' is not defined.                                        1
Expected '{' and instead saw 'value'.                            1
Expected '{' and instead saw 'css'.                              1
Redefinition of 'clearInterval'.                                 1
Use '===' to compare with 'true'.                                1
'__add__' is not defined.                                        1
'__recursivelyGatherText__' is not defined.                      1
Expected '{' and instead saw 'appendSelector'.                   1
'__formSerialize__' is not defined.                              1
're_invalidStringChars' is not defined.                          1
Expected '{' and instead saw 'appendString'.                     1
'parseFormat' is not defined.                                    1
Use '!==' to compare with 'undefined'.                           1
Missing 'new' prefix when invoking a constructor.                1
Expected '{' and instead saw 'appendObject'.                     1
Expected '{' and instead saw 'appendInteger'.                    1
'node' is not defined.                                           1
Expected '{' and instead saw 'appendObjectFormatted'.            1
're_validName' is not defined.                                   1
'url' is not defined.                                            1
['height'] is better written in dot notation.                    1
Redefinition of 'setInterval'.                                   1
Expected '{' and instead saw 'parent'.                           1
'value' is not defined.                                          1
'leftover' used out of scope.                                    1
Redefinition of 'XMLHttpRequest'.                                1
'$availleft' is not defined.                                     1
'__toDomNode__' is not defined.                                  1
Expected '{' and instead saw 'appendNode'.                       1
'ns' is already defined.                                         1
Expected '{' and instead saw 'console'.                          1
'__dispatchEvent__' is not defined.                              1
'__supportedStyles__' is not defined.                            1
'__getElementsByTagNameRecursive__' is not defined.              1
'__updateCss2Props__' is not defined.                            1
'__addEventListener__' is not defined.                           1
'__remove__' is not defined.                                     1
Expected '{' and instead saw 'break'.                            1
Expected '{' and instead saw 'throw'.                            1
Expected '{' and instead saw 'text'.                             1
'Window' was used before it was defined.                         1
'HTMLULElement' is not defined.                                  1
'nodeList' is not defined.                                       1
'__clearField__' is not defined.                                 1
'$availLeft' is not defined.                                     1
'__captureEvent__' is not defined.                               1
'HTMLParser' is not defined.                                     1
'tmp' is already defined.                                        1
Redefinition of 'Image'.                                         1
['width'] is better written in dot notation.                     1
Redefinition of 'Option'.                                        1
Expected '{' and instead saw 'event'.                            1
'$implementation' is not defined.                                1
'leftover' is already defined.                                   1
Expected '{' and instead saw 'returnedHeaders'.                  1
Line breaking error 'break'.                                     1
'input' is not defined.                                          1
Redefinition of 'setTimeout'.                                    1
This 'switch' should be an 'if'.                                 1
'__getElementsByTagNameNSRecursive__' is not defined.            1
Expected '{' and instead saw 'appendFunction'.                   1
Expected '{' and instead saw 'bubbles'.                          1
'XPathExpression' is not defined.                                1
'appendSelector' is not defined.                                 1

TOTAL ERRORS: 592

I haven't mentioned it, but I kinda don't like the single mother of all closures. Having closures span files confuses some tools and I find it makes it easy to create pseudo-globals that have a lot of the negative consequences of real globals: hard to track down modifications, easy to have collisions, etc.

Seems like it'd be easy enough to create a global object in an intro.js and delete it in an outro.js. Files could have individual closures to capture it. And it could be mocked for testing.

Seems like scoping between files would be a lot clearer.

I don't know if this a really good idea or a really bad idea ...

well I committed some easy fixes between meeting. Only 482 to go. Actually, I don't care about 100% "correct" in jslint's eyes, but it's better than nothing. Certainly trying to set all "Missing semi-colons" and "eval is a keyword" fixed up in attempt to allow this to be minified correctly.

In case you think this is all bs:

'node' is not defined.

is an actually bug that would crash envjs.

Anyways, fun stuff.

@steve: re: I haven't mentioned it, but I kinda don't like the single mother of all closures

I more or less agree. I have to run but let's talk later on this.