Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

getElementByTagName needs tests

#147

Found this..
JS strict warning #156 in env.js at line 1738 - assignment to undeclared variable nodeList

which lead to this in node.js

    getElementsByTagName : function(tagname) {
        // delegate to _getElementsByTagNameRecursive                                                                      
        // recurse childNodes                                                                                              
    var nodelist = new NodeList(__ownerDocument__(this));
        for(var i = 0; i < this.childNodes.length; i++) {
            nodeList = __getElementsByTagNameRecursive__(this.childNodes.item(i), tagname, nodelist);
        }
        return nodelist;
    },

looks like nodeList vs nodelist. Might have been caused by me with some editor problem.

Need tests.

Reported by nickg · April 2nd, 2010 @ 03:46 AM

State: resolved
Milestone: none
Assigned to: nickg nickg

Activity

  1. nickg
    nickg
    • State changed from new to open
    • Assigned user set to nickg

    I have a test just need to check it in

    "nodeList" is just bogus can be removed.....

    April 2nd, 2010 @ 12:21 PM

  2. nickg
    nickg
    • State changed from open to resolved

    tests were committed a few days ago.

    resolving.

    April 6th, 2010 @ 03:56 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.