Activity (RSS)

note: this patch also fixes ticket 106 about XMLHttpRequest constants.

http://envjs.lighthouseapp.com/projects/21590/tickets/106-incorrect...

It's not pretty but it does the job: http://github.com/FroMage/env-js/commit/3fdd7797a721f801e363eb87a10...

Hi, thanks FroMage...

Found the other problem... a missing comma. Gotta love javascript.

function __cookieString__(cookies, doc) {
    var cookieString = ""   ...

Hi,

This commit fixes the cookie.js inclusion in the build, but perhaps not your bug: http://github.com/FroMage/env-js/commit/37e6bb9af89f22a8e5bf6f8e051...

It...

FYI -- just adding html/cookie.js to build script isn't quite enough.

js> document.cookie
js: "client9-env-js/dist/env.rhino.js", line 6604: uncaught JavaScrip...

Tried reopening ticket #8. Oddly if you comment on a resolved ticket, it does not reopen it.

$ ./tester.sh Rhino 1.7 release 2 2009 03 22
js> load("client9-env-...

Ok this gives me some ideas on how to make global timeout really easy.

Seem like it might be as simple as replacing

Envjs.wait();

with

Envjs.wait(Envjs.MAXTI...

There's code that makes the parser sync to handle innerHTML, which can't have script tags and so can't do document.write.

As far as I know, there's no way to se...

Hi again,

I don't know if it's your domain or not, but you might find ticket 107 interesting:
http://envjs.lighthouseapp.com/projects/21590/tickets/107-on-page...

There are a couple of places where there are waits to support the parser, which does some things async (in order to support document.write). Those generally cal...

Hi Steve,

I think you are right about the event loop. The problem is the "README" says the caller (you), is suppose to manually call Envjs.wait() after the init...

aha. learn something new everyday!

CLOSE ME!

The parsing is not complete at the end of the parseDocument precisely because the parser is async, which is why the wait is there. The parsing is taking 480 ms.

No,it's env-js. (craigslist doesn't like "fake browsers", and redirects or drops connections if you use say curl).

oddly not as bad as if you load it from a fil...

ignore this for now. Might be craigslist doing something odd.

My bad -- Operator error -- thatcher, please close

[[ original deleted ]]

In my envjs-like thing, I did something like the following:

// img                                                                                             ...

looks like Image is missing in envjs.

Image is a weirdo in the DOM, since it actually has a constructor, and doesn't need an OwnerDocument.

For ref, https://dev...

Like "Image", "Option" is the other weirdo in the DOM that has a constructor.

$ ./tester.sh
Rhino 1.7 release 2 2009 03 22
js> Option
js: "<stdin>", line 2: un...

wow github must have a wiki bug.

Hola,

I'm not quite sure how to attach a patch, but this patch is 100% backwards compatible.

The current [before|after]ScriptLoad only allows you to intercept e...

Reopen!

$ ./tester.sh Rhino 1.7 release 2 2009 03 22
js> load("client9-env-js/dist/env.rhino.js");
[ Envjs/1.6 (Rhino; U; Mac OS X x86_64 10.6.2; en-US; rv:1.7....

prototype.js has the following gem:

(function() {                                                                                                              ...

word up.

Yeah, I have no idea what happens on the other end of the pull request (like what happens when you get it or what it says). I'll always file a ticket s...

ps as far as best process goes for pull requests, im not sure. Right now I
like using Lighthouse because we can actually respond using just email and
it forces ...

thats awesome thanks

fyi -- I'm working on adding unit tests for Envjs.uri as a way of learning my way around envjs, and also see if it can't be 100% javascript. (will help in porti...

Fixed in commit http://github.com/thatcher/env-js/commit/2cc8e59da146072ba79c5a07cc...
Please close

regarding XMLHttpRequest.js

// it would be nice if these w...

I attempted a github pull request which may or may not work!
it's a tester before more interesting changes.

--nickg

opps that formatting wasn't very good:

The README file says:

Testing:
* Checkout qunit: "git submodule update --init"
* run "ant test"

Testing:
* Checkout qunit: "git submodule update --init" * run "ant test"

I don't think you need to checkout quint separately anymore. It seems bundled.

ant tes...

In env-js/src/platform/rhino @ line 251

    xhr.responseText = java.nio.charset.Charset.forName("UTF-8").
        decode(java.nio.ByteBuffer.wrap(baos.toByteAr...

Looks like the trunk has an unintended debug console.log in place. All others in the source are commented out.

Around line 132 in src/eventtarget.js

        if...

Should be alias to Envjs.uri but barked as deprecated

I think the event loop already has this functionality, in that wait can be called with a maximum amount of time to wait. The bigger issue then is how to get the...

@thatcher : not sure how github works. nickg is fine, but client9 is ok too.

@sephr: still need to use try/catch since DOMException exists, but one can't make a...

nick I was going to add you as a collaborator on the env-js project. do you
want me to add client9 or nickg ?

Thanks for the tips (again).

@thatcher: go for it. I'm not working any tickets.

@all don't be scared that I just forked envjs. Its just so I have aplace to dump...

Also, I should mention that all errors (it's practically a standard) must have a message and name property. So if you find yourself ever absolutely needing to u...

nickg: For making your own error classes, please piggyback on Error or the appropriate error type, so magic metadata can propagate. new Error magically includes...