Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Activity (RSS)

Sunday, March 21 2010
126 Add HTMLScriptElement.toString was created
  • nickg
    nickg created the ticket at 3:33 PM

    just needs:

        toString: function() { return '[object HTMLScriptElement]'; }
    
125 document.referrer should not be undefined (empty string ok) was created
  • nickg
    nickg created the ticket at 3:32 PM

    document.referrer should not return undefined. If MIA, then return ''

101 PATCH: API to put maximum time limit on timers/intervals was updated
  • nickg
    • Title changed from PATHC: API to put maximum time limit on timers/intervals to PATCH: API to put maximum time limit on timers/intervals
    by nickg at 2:48 PM
  • nickg
    • State changed from new to open
    • Assigned user set to nickg
    • Title changed from API to put maximum time limit on timers/intervals (patch) to PATHC: API to put maximum time limit on timers/intervals
    by nickg at 2:47 PM

    Turns out actually is easy, with almost no code change (again thanks to the groundwork already laid -- thank you). This is the spot to change.

    var __exchangeHT...
124 Make sure 'print' is not used directly in envjs was updated
  • nickg
    • State changed from new to open
    by nickg at 2:41 PM

    This is easier than I expected since the groundwork has already been laid. All that needs to change is in src/platform/rhino/console.js

    Envjs.log = function(ms...
  • nickg
    nickg created the ticket at 12:36 PM

    A webpage from a Large Site had this tidbit.

    function print(pageName) {
        window.open(pageName, "Print", "scrollbars=yes,menubar=yes,resizable=yes,width=680,...
123 PATCH: do not use "document.all" internally was updated
fix typo in last commit http://github... was committed by Nick at 12:23 PM
do not use this.all internally http:/... was committed by Nick at 12:23 PM
112 Option is not defined was updated
  • nickg
    • State changed from new to open
    • Assigned user set to nickg
    by nickg at 12:19 PM
105 README needs editing/revision was updated
  • nickg
    • Title changed from README has lists invalid ant build target "test" to README needs editing/revision
    by nickg at 12:18 PM

    I found how to edit a ticket title. yay.

117 setting Image.src explodes was updated
120 PATCH: HTMLImageElement.toString is incorrect was updated
fix HTMLImageElement.toString, with t... was committed by Nick at 12:15 PM
allow setting of img.src, ticket #117... was committed by Nick at 12:15 PM
122 PATCH: default value for CSS property "background-color" was updated
give background-color a string defaul... was committed by Nick at 12:03 PM
115 Cleanup of Envjs.uri was updated
  • nickg
    • State changed from new to open
    • Assigned user set to nickg
    by nickg at 11:30 AM

    @steve -- will post that code to github, I promise.

    @all

    I think this all the places that need consolidating.

    • img.src
    • a.href
    • window.location
    • document.location ...
test commit: add common about commonj... was committed by Nick at 11:26 AM
95 implement btoa and atob was updated
  • nickg
    • Assigned user changed from Thatcher to nickg
    by nickg at 11:03 AM

    nickg to add smoke tests, then this can be closed.

109 document.cookie does not exist was updated
  • nickg
    • State changed from new to resolved
    by nickg at 11:02 AM

    closing since original issue was solved. Thatcher may with to open a new ticket on the other issue with cookies.

116 PATCH: Typo in cookie.js/document.js "splt" should be "split" was updated
nickg nickg was invited to envjs at 10:55 AM
121 For some reason window.location is working but document location is not was updated
  • d0rc
    • Assigned user set to Thatcher
    by d0rc at 5:08 AM
Saturday, March 20 2010
122 PATCH: default value for CSS property "background-color" was created
  • nickg
    nickg created the ticket at 3:54 AM

    I bumped into this testing with a large website. It did (I forget the exact mechanism) (getComputedStyle" or something ...).backgroundColor.toLower() == ...

    It ...

Friday, March 19 2010
115 Cleanup of Envjs.uri was updated
  • nickg
    nickg commented at 2:48 PM

    Thanks, and it's MIT. And sure, I'm happy to post it to github if that's your pref!

    I only went with the python stuff cause, well, it was easiest for me. I have...

  • Steven Parkes
    Steven Parkes commented at 2:32 PM

    Yeah, I know there's a URI spec. And there's also a URL spec. I was misremembering: it's not that there's isn't a spec for file URLs: that's actually described ...

  • nickg
    nickg commented at 2:02 PM

    re: ... Python API for this, though. Just breaking things down to a tuple ... a fixed tuple ... I don't think that's a general solution.

    Actually it returns a w...

  • Steven Parkes
    Steven Parkes commented at 1:44 PM

    Pretty cool ... and a lot of the plumbing.

    I have to admit, I've never been crazy about the Python API for this, though. Just breaking things down to a tuple .....

  • nickg
    nickg commented at 1:15 PM

    Steve, I have scratched your itch! The code i'm using is in javascript .

    url a + url b is urljoin(a,b)!

    urlsplit breaks down the url is all sorts of form (urlsp...

3 earlier changes…
  • Steven Parkes
    Steven Parkes commented at 1:08 PM

    I haven't used the Python url stuff in a while. (Obviously) the Ruby port uses the Ruby classes. They've got some really nice features. They'll do url_a + url_b...

  • nickg
    nickg commented at 12:50 PM

    re:Rather than doing the indexof stuff, just using a uri parse on the path? Then you can just look at the scheme and see if it's javascript or about?

    Yeah, that...

  • Steven Parkes
    Steven Parkes commented at 8:14 AM

    Rather than doing the indexof stuff, just using a uri parse on the path? Then you can just look at the scheme and see if it's javascript or about?

121 For some reason window.location is working but document location is not was created
  • d0rc
    d0rc created the ticket at 12:53 PM

    These things should exist:

    document.location.hash,
    document.location.host,
    document.location.hostname,
    document.location.href,
    document.location.pathname,
    docum...

Thursday, March 18 2010
108 prototype.js won't load due it clobbering "Element" was updated
  • nickg
    nickg commented at 7:31 PM

    update
    so prototype 1.5 is fine
    prototype 1.6 explodes.
    boo

119 fix empty script tags was updated
115 Cleanup of Envjs.uri was updated
  • nickg
    nickg commented at 6:42 PM

    argh, ignore that last post. of course the one thing I didnt unit-test had a bug.

    To test, you'll need my copy of src/platform/rhino/xhr.js

    Cut-n-Paste with
    ht...

  • nickg
    nickg commented at 6:20 PM

    This is not a patch that should be commited to The Master, but it can be used to test with.

    http://github.com/client9/env-js/commit/3fbc94d726681ca9d843ccb5972...

  • nickg
    nickg commented at 1:02 PM

    ok, it's getting close and handles normalization of file w.r.t to query strings and whatnot.

    So far I have 185 asserts in my unit test for the generic case.
    And...

118 fix script tags with ? after the file name was updated
  • nickg
    nickg commented at 6:41 PM

    of course the one thing I didnt unit-test had a bug.

    I'm not really sure how to tell you the best way to grab my copy of src/platform/rhino/xhr.js.

    Cut-n-Paste ...

  • nickg
    nickg commented at 6:21 PM

    hola,

    You can pull this in, and you should be able to move forward, however it's not the final patch.

    http://github.com/client9/env-js/commit/3fbc94d726681ca9d...

  • Thatcher
    Thatcher commented at 6:59 AM

    This would imply use of the file:// protocol. Are you wanting to load from
    a server via http? I use envjs for both but we do have general issues with
    the query ...

  • Brian Moschel
    Brian Moschel commented at 6:17 AM

    Actually I'm not sure. I'm invoking Envjs with a relative URL like this:

    Envjs('callcenter/funcunit.html')
    
  • nickg
    nickg commented at 5:40 AM

    hi again,

    and in this case you are loading the original document as a file, not http? (just checking)

120 PATCH: HTMLImageElement.toString is incorrect was created